Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GCC to test_size_of_spdm_* for aarch64 #2597

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Add GCC to test_size_of_spdm_* for aarch64 #2597

merged 2 commits into from
Feb 28, 2024

Conversation

steven-bellock
Copy link
Contributor

@steven-bellock steven-bellock commented Feb 28, 2024 •
edited
Loading

Fix #2596.

Also fixes it for CLANG.

Signed-off-by: Steven Bellock [email protected]

@steven-bellock steven-bellock added bug Something isn't working build Build system labels Feb 28, 2024
@steven-bellock steven-bellock marked this pull request as ready for review February 28, 2024 19:02
@steven-bellock steven-bellock changed the title Add TOOLCHAIN==GCC to test_size_of_spdm_* Add GCC to test_size_of_spdm_* for aarch64 Feb 28, 2024
@steven-bellock
Copy link
Contributor Author

steven-bellock commented Feb 28, 2024 •
edited
Loading

Note that we currently don't have native aarch64 support in CI/CD, although that might be coming. This pull request was tested locally on a

Architecture:           aarch64
  CPU op-mode(s):       32-bit, 64-bit
  Byte Order:           Little Endian
CPU(s):                 128
  On-line CPU(s) list:  0-127
Vendor ID:              ARM
  Model name:           Neoverse-N1

twilfredo
twilfredo approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@twilfredo twilfredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to test this on actual hardware right now, lgtm :)

@steven-bellock steven-bellock merged commit b593306 into DMTF:main Feb 28, 2024
95 checks passed
@steven-bellock steven-bellock deleted the fix-2596 branch February 28, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twilfredo twilfredo twilfredo approved these changes

@alistair23 alistair23 Awaiting requested review from alistair23

Assignees
No one assigned
Labels
bug Something isn't working build Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_size_of_spdm_* build fails on aarch64
2 participants
@steven-bellock @twilfredo